Skip to content

Add granularity to progress reporting #289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Add granularity to progress reporting #289

wants to merge 3 commits into from

Conversation

facchinm
Copy link
Member

@facchinm facchinm commented Sep 5, 2018

@facchinm
[Progress] Avoid using globally shared step size
a52d469 
The code in a32d158 was tested with "arduino-preprocessor" build, which greatly reduced the number of substeps for that runCommand.
Removing dependency on globally shared stepSize allows a "softer" grow, within the already recognized limits (final result exceeds 100%)
@facchinm
Slightly adjust step size based on libraries in use
a7a04b2
@facchinm
Add steps reporting for ContainerFindIncludes
7e5d1b6 
Set granularity to 20 and hard limit the final steps count since we don't know anything about how many files are going to be scanned
@ArduinoBot
Copy link
Contributor

✅ Build completed.

⬇️ Build URL: http://downloads.arduino.cc/PR/arduino-builder/arduino-builder-289.zip

ℹ️ To test this build:

  1. Replace arduino-builder binary (you can find it where you installed the IDE) with the provided one

@facchinm facchinm added this to the next milestone Sep 20, 2018
facchinm added a commit to facchinm/arduino-cli that referenced this pull request Aug 27, 2019
@facchinm
Fix progressbar
7f8fb33 
Port of arduino/arduino-builder#289
facchinm added a commit to facchinm/arduino-cli that referenced this pull request Aug 27, 2019
@facchinm
Fix progressbar
cdf5020 
Port of arduino/arduino-builder#289
facchinm added a commit to facchinm/arduino-cli that referenced this pull request Aug 27, 2019
@facchinm
Fix progressbar
c5d1075 
Port of arduino/arduino-builder#289
@cmaglie cmaglie mentioned this pull request Mar 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
next
Development

Successfully merging this pull request may close these issues.

Compiling Sketch Progress Bar is Ineffective
2 participants
@facchinm @ArduinoBot